This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/4] [BZ #14161] tst-strptime2.c: add %z minute and range limit tests

On 03 Dec 2014 14:45, James Perkins wrote:
> * Two of the new offsets fail, showing that strptime incorrectly
>   calculates the seconds from minutes not divisible by 3 (+1158, +1159).

these are good datasets to have as they show the bug exists before your fix, but 
generally we don't add tests to the tree that fail right away.  for example, 
this makes bisecting harder.  instead you should merge the test updates with the 
code fix so there is only one patch.

> 2014-12-03  James Perkins

your email address should have angle brackets like <foo@com>

> 	* time/strptime2.c (tests[]): Add tests for the strptime %z

when fixing bugzilla bugs, the ChangeLog should have a line above it here:
	[BZ #12345]

when scoping the changelog entry, we just use the name, not its type.
i.e. drop the [] so you have "(tests)".

also, your subject line seems to have a typo -- you want #16141, not #14161.

Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]