This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #18080] S390: Fix setcontext/swapcontext which are not restoring sigmask.


On 03/04/2015 12:26 PM, Stefan Liebler wrote:
> +volatile int handlerCalled;

I think this should use sigatomic_t.

There are a few missing spaces in function calls:

> +check(const char *funcName)
> +  sigprocmask(SIG_BLOCK, NULL, &set);
> +  if (sigismember(&set, SIGUSR2) != 0)
> +  if (sigismember(&set, SIGUSR1) == 0)
> +  if (sigismember(&set, SIGUSR2) == 0)
> +  if (sigismember(&oldctx.uc_sigmask, SIGUSR2) == 0)
> +  if (sigismember(&oldctx.uc_sigmask, SIGUSR1) == 0)

Sorry, no other comments at this time.

-- 
Florian Weimer / Red Hat Product Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]