This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/25] Remove extend_alloca [BZ #18023]

On Mon, 2 Mar 2015, Florian Weimer wrote:

> This series of patches removes extend_alloca.
> I tried to split up the patches by subsystems, and separate patches
> which address different coding patterns.

Did any of the cases changed previously involve unbounded stack usage for 
any supported glibc configuration (rather than simply more usage than 
intended)?  If so, they should have their own bugs filed in Bugzilla, as 
bugs that were user-visible in a release.

> Most extend_alloca uses were converted to a set of helper functions
> around the new type struct scratch_buffer.  This facility uses a
> fixed-size stack allocation with malloc fallback if the requested buffer
> size exceeds the stack allocation.

Do all these cases (or other cases using malloc now) already have safety 
annotations in the manual that indicate that they may call malloc?  If 
not, the safety annotations need updating, and if making some function 
newly call malloc, this needs to be OK with any POSIX requirements on 
safety of that function.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]