This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] manual/memory.texi: Remove locale from muntrace's markings

On 03/03/2015 08:28 AM, Ma Shimiao wrote:
> diff --git a/manual/memory.texi b/manual/memory.texi
> index 0729e70..a77c2dc 100644
> --- a/manual/memory.texi
> +++ b/manual/memory.texi
> @@ -1700,9 +1700,13 @@ systems.  The prototype can be found in @file{mcheck.h}.
>  @comment mcheck.h
>  @comment GNU
>  @deftypefun void muntrace (void)
> -@safety{@prelim{}@mtunsafe{@mtasurace{:mtrace} @mtasuconst{:malloc_hooks} @mtslocale{}}@asunsafe{@asucorrupt{} @ascuheap{}}@acunsafe{@acucorrupt{} @acsmem{} @aculock{} @acsfd{}}}
> +@safety{@prelim{}@mtunsafe{@mtasurace{:mtrace} @mtasuconst{:malloc_hooks}}@asunsafe{@asucorrupt{} @ascuheap{}}@acunsafe{@acucorrupt{} @acsmem{} @aculock{} @acsfd{}}}
> +@c As we know, only if we passes custom string format or format which 
> +@c contains single quota to fprintf(), locale problem will occur. 
> +@c Though calls function fprintf(), muntrace() will not execute the
> +@c area which causes locale problem.

The locale dependency is also exposed by floating point formatting (%f
for example) because the decimal separator is not always a point.  So I
think your new comment is misleading.

Florian Weimer / Red Hat Product Security

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]