This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions


On Mon, Mar 02, 2015 at 10:40:46AM +0100, Florian Weimer wrote:
> On 03/02/2015 10:35 AM, Andreas Schwab wrote:
> > Florian Weimer <fweimer@redhat.com> writes:
> > 
> >> +#pragma once
> > 
> > Don't use pragma once.
> 
> Why?  The GCC implementation was fixed ages ago, and it's not an
> installed header file.

If for no other reason, cargo-culting. This is the wrong way to
achieve multiple-include protection (it's non-portable and has a
perfectly portable way to do the same thing) and programmers will see
and copy it into non-glibc code.

Rich


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]