This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Update timex.h for ADJ_SETOFFSET.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Miroslav Lichvar <mlichvar at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Tue, 24 Feb 2015 16:16:25 +0000
- Subject: Re: [PATCH] Update timex.h for ADJ_SETOFFSET.
- Authentication-results: sourceware.org; auth=none
- References: <1418743574-29087-1-git-send-email-mlichvar at redhat dot com> <20150224054738 dot GC6655 at vapier> <alpine dot DEB dot 2 dot 10 dot 1502241139260 dot 5543 at digraph dot polyomino dot org dot uk> <20150224153457 dot GD6655 at vapier>
On Tue, 24 Feb 2015, Mike Frysinger wrote:
> On 24 Feb 2015 11:39, Joseph Myers wrote:
> > On Tue, 24 Feb 2015, Mike Frysinger wrote:
> > > On 16 Dec 2014 16:26, Miroslav Lichvar wrote:
> > > > ADJ_SETOFFSET is a new adjtimex() mode that can be used to precisely
> > > > step the clock. It was introduced in kernel 2.6.39.
> > >
> > > OK
> >
> > When reviewing patches by people without write access, you need to commit
> > the patches for them, not just say "OK".
>
> i'm aware, but i have no idea who on the list has commit access. there's too
> many for me to try and remember. so i just wait for the poster to respond that
> they need assistance.
That's the wrong way round. People without write access also won't know
that they need to respond like that; you need to avoid assuming such
knowledge of them. The MAINTAINERS page on the wiki has a list of people
with write access. This applies also to some other recent reviews of
yours, e.g. <https://sourceware.org/ml/libc-alpha/2015-02/msg00604.html>
and <https://sourceware.org/ml/libc-alpha/2015-02/msg00649.html>.
--
Joseph S. Myers
joseph@codesourcery.com