This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Cleanup #includes in preparation for BZ#16734 fix


Greetings,

Following up on Joseph's suggestion of fixing the bugs before
committing the s/ALLOC_BUF/malloc/ patch, I tried building glibc with
the following (not intended to commit):

diff --git a/libio/libioP.h b/libio/libioP.h
index d8604ca..d1699de 100644
--- a/libio/libioP.h
+++ b/libio/libioP.h
@@ -719,7 +719,7 @@ extern _IO_off64_t _IO_seekpos_unlocked (_IO_FILE
*, _IO_off64_t, int)
 # endif
 #endif

-#if _G_HAVE_MMAP
+#if _G_HAVE_MMAP && 0

 # include <unistd.h>
 # include <fcntl.h>
@@ -737,7 +737,7 @@ extern _IO_off64_t _IO_seekpos_unlocked (_IO_FILE
*, _IO_off64_t, int)

 #endif /* _G_HAVE_MMAP */

-#if _G_HAVE_MMAP
+#if _G_HAVE_MMAP && 0

 # ifdef _LIBC
 /* When using this code in the GNU libc we must not pollute the name space.  */

That failed to build, due to missing #includes.

Attached trivial patch fixes that.

Thanks,


2015-02-16  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * libio/fileops.c: Add missing sys/mman.h
        * libio/iopopen.c: Add missing fcntl.h, remove redundant unistd.h


-- 
Paul Pluzhnikov

Attachment: bz16734-cleanup.patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]