This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/8] Function declaration cleanup
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 06 Jan 2015 14:48:31 -0200
- Subject: Re: [PATCH 2/8] Function declaration cleanup
- Authentication-results: sourceware.org; auth=none
- References: <5435AD75 dot 1060405 at linux dot vnet dot ibm dot com> <20141008215213 dot 8B44D2C3AC5 at topped-with-meat dot com> <54369E9D dot 5020201 at linux dot vnet dot ibm dot com> <20141009171455 dot CB1F12C3AD1 at topped-with-meat dot com> <CAMe9rOre7aJCqvQ6AUedkD=XJ8314y=y+NyFTH3RcuMsU=7bvA at mail dot gmail dot com>
On 06-01-2015 14:25, H.J. Lu wrote:
> On Thu, Oct 9, 2014 at 10:14 AM, Roland McGrath <roland@hack.frob.com> wrote:
>>> On 08-10-2014 18:52, Roland McGrath wrote:
>>>> This sort of change should get the "no disassembly of compiled code
>>>> changed" test rather than the vanilla "no regressions" test. With that
>>>> testing, changes like this can count as "obvious enough".
>>>>
>>> Thanks, I compared the dissassembly of compiled code and it shows no change.
>>> Is that ok to apply?
>> Yes. What I meant to communicate is that whenever you have a
>> prototypification change, just verifying that it doesn't change the
>> compiled code is enough to commit it without explicit approval from
>> another person. (Of course it never hurts to let people look it over for
>> typos or bad indentation or whatever, but when you're confident you got
>> those trivia correct, you can just commit without waiting for replies.)
>>
> I am cleaning up patchwork queue. I checked in this patch.
>
>
Thanks.