This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Andreas Schwab <schwab at linux-m68k dot org>
Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 06 Jan 2015 07:57:56 -0800
Subject: Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
Authentication-results: sourceware.org; auth=none
References: <20150105204653 dot GA31001 at intel dot com> <54AB1115 dot 80608 at cs dot ucla dot edu> <CAMe9rOrExjqKKFUkjcN+4SzzouGQ7yyq8RnfWxKmotEaQ6aZRQ at mail dot gmail dot com> <CAMe9rOpBRqzqwhefrKG9eZro8qXwRBc=+-WT5Wx4xbNMzJJ3fg at mail dot gmail dot com> <CAMe9rOoZPZAfWt_jfci2XOhPcJde09mOz8RtCs_6S1dqU5OzqA at mail dot gmail dot com> <54AB2185 dot 2060402 at cs dot ucla dot edu> <CAMe9rOrpk5vHFjL=EFNByhwBSj34zYFc7+YyfyCUt8JJjD0idw at mail dot gmail dot com> <54AB68E7 dot 7050903 at cs dot ucla dot edu> <87a91wt2e8 dot fsf at igel dot home>

On 01/06/2015 06:22 AM, Andreas Schwab wrote:

This fails only at runtime if the value is wrong, which is not as good as
>checking it at compile-time.

Does it matter?

Not so much here, no, since the constant is always 1 million and theassert is optimized away. Still, we should prefer compile-time checking.

References:
- [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: H.J. Lu
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: Paul Eggert
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: H.J. Lu
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: H.J. Lu
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: H.J. Lu
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: Paul Eggert
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: H.J. Lu
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: Paul Eggert
- Re: [PATCH] Define CLOCKS_PER_SEC type to the type clock_t
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]