This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix MIPS variable PAGE_SIZE bug (16191) [committed]


Patch split out from:
https://sourceware.org/ml/libc-ports/2013-12/msg00017.html
Pre-approved by Joseph.

MIPS supports a variable page size but glibc defines a constant.
This causes at least two glibc tests to fail when the page size
does not match the hard-coded size:

inet/test-ifaddrs
inet/test_ifindex

     [BZ #16191]
     * NEWS: Mention bug fix.
     * sysdeps/unix/sysv/linux/mips/sys/user.h (PAGE_SHIFT): Remove.
     (PAGE_SIZE, PAGE_MASK, NBPG, UPAGES): Likewise.
     (HOST_TEXT_START_ADDR, HOST_DATA_START_ADDR): Likewise.
     (HOST_STACK_END_ADDR): Likewise.
---
ChangeLog                               |  9 +++++++++
NEWS                                    | 14 +++++++-------
sysdeps/unix/sysv/linux/mips/sys/user.h |  9 ---------
3 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/mips/sys/user.h b/sysdeps/unix/sysv/linux/mips/sys/user.h
index a249dd4..286fd57 100644
--- a/sysdeps/unix/sysv/linux/mips/sys/user.h
+++ b/sysdeps/unix/sysv/linux/mips/sys/user.h
@@ -206,13 +206,4 @@ struct user {

 #endif

-#define PAGE_SHIFT        12
-#define PAGE_SIZE         (1UL << PAGE_SHIFT)
-#define PAGE_MASK         (~(PAGE_SIZE-1))
-#define NBPG              PAGE_SIZE
-#define UPAGES            1
-#define HOST_TEXT_START_ADDR   (u.start_code)
-#define HOST_DATA_START_ADDR   (u.start_data)
-#define HOST_STACK_END_ADDR    (u.start_stack + u.u_ssize * NBPG)
-
#endif    /* _SYS_USER_H */
-- 
1.9.4




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]