This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix wordsize-64 posix_fadvise64, posix_fallocate64 namespace (bug 17777)
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 5 Jan 2015 06:31:15 -0800
- Subject: Re: Fix wordsize-64 posix_fadvise64, posix_fallocate64 namespace (bug 17777)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1412302258310 dot 17381 at digraph dot polyomino dot org dot uk>
On Tue, Dec 30, 2014 at 3:00 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On systems using sysdeps/unix/sysv/linux/wordsize-64, posix_fadvise64
> and posix_fallocate64 (non-POSIX) are strong aliases for posix_fadvise
> and posix_fallocate (POSIX), meaning references to the latter wrongly
> bring in definitions of the former. They should be weak aliases; this
> patch makes them so.
>
> Tested for x86_64 (testsuite, and that disassembly of installed shared
> libraries is unchanged by the patch).
>
> 2014-12-30 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #17777]
> * sysdeps/unix/sysv/linux/wordsize-64/posix_fadvise.c
> (posix_fadvise64): Define as weak alias not strong alias.
> * sysdeps/unix/sysv/linux/wordsize-64/posix_fallocate.c
> (posix_fallocate64): Likewise.
> * conform/Makefile (test-xfail-XOPEN2K/fcntl.h/linknamespace):
> Remove variable.
> (test-xfail-XOPEN2K/mqueue.h/linknamespace): Likewise.
> (test-xfail-POSIX2008/fcntl.h/linknamespace): Likewise.
> (test-xfail-POSIX2008/mqueue.h/linknamespace): Likewise.
> (test-xfail-XOPEN2K8/fcntl.h/linknamespace): Likewise.
> (test-xfail-XOPEN2K8/mqueue.h/linknamespace): Likewise.
>
Looks good to me.
Thanks.
--
H.J.