This is the mail archive of the
mailing list for the glibc project.
Re: [Patch, MIPS] Modify memcpy.S for mips32r6/mips64r6
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: Joseph Myers <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>
- Date: Tue, 23 Dec 2014 09:34:48 -0800
- Subject: Re: [Patch, MIPS] Modify memcpy.S for mips32r6/mips64r6
- Authentication-results: sourceware.org; auth=none
- References: <7ec2bf7e-fc1e-428b-ac0a-747f2a3ab3e6 at BAMAIL02 dot ba dot imgtec dot org> <alpine dot DEB dot 2 dot 10 dot 1412221758190 dot 5278 at digraph dot polyomino dot org dot uk> <1419354526 dot 27606 dot 73 dot camel at ubuntu-sellcey> <20141223172540 dot GA5360 at domone>
- Reply-to: <sellcey at imgtec dot com>
On Tue, 2014-12-23 at 18:25 +0100, Ondřej Bílka wrote:
> > Here is a new memcpy patch. It has just the changes needed for
> > mips32r6/mips64r6 support. Note that there are still some preprocessor
> > indentation changes where existing ifdefs are now under a newly
> > introduced !R6_CODE ifdef.
> > Tested with the mips32r6/mips64r6 GCC, binutils and qemu simulator.
> > OK to checkin?
> still contains likely performance regression. using indirect jumps is
> slow, try different approaches.
There is no performance regression for existing MIPS architectures
because that code has not changed. The code may not be optimal for
mips32r6/mips64r6 (yet) but I would rather get the functionality in
now and optimize it later instead of trying to get it perfect
immediately. Especially with a release coming up soon.