This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Ping^18 Re: Make __ASSUME_UTIMES hppa-specific
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Kyle McMartin <kmcmarti at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 23 Dec 2014 10:11:49 -0500
- Subject: Re: Ping^18 Re: Make __ASSUME_UTIMES hppa-specific
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1410201527330 dot 12154 at digraph dot polyomino dot org dot uk> <Pine dot LNX dot 4 dot 64 dot 1410271227170 dot 13536 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1411031812130 dot 26067 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1411101354020 dot 27220 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1411181514120 dot 11642 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1411241648010 dot 31267 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1412011814150 dot 32616 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1412081614370 dot 3449 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1412161534380 dot 15637 at digraph dot polyomino dot org dot uk> <alpine dot DEB dot 2 dot 10 dot 1412221308230 dot 11756 at digraph dot polyomino dot org dot uk> <20141222213040 dot GC16877 at redacted dot bos dot redhat dot com>
On 12/22/2014 04:30 PM, Kyle McMartin wrote:
> On Mon, Dec 22, 2014 at 01:08:37PM +0000, Joseph Myers wrote:
>> Ping^18. This patch
>> <https://sourceware.org/ml/libc-alpha/2014-06/msg00758.html> is still
>> pending review for hppa.
>>
>
> for what good it is, your patch looks fine... though i question the
> utility of even bothering to wire up utimes() when asm-generic/unistd.h
> using architectures are never going to have it... it seems hppa'd be
> better off sticking to their guns and let arm64 deal with it, since
> that'll have more clout as a non-boat-anchor architecture.
Thanks for the review. I kept meaning to get to this, but to be honest
I'm just barely getting through the -Werror fixes for hppa (and even
then had to hack a set of new fans to boot my box).
Cheers,
Carlos.