This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6


On Mon, 22 Dec 2014, Steve Ellcey wrote:

> Would sysdeps/unix/mips/sysdep.h be an appropriate place to define
> __mips_isa_rev?  That header is already used by memcpy and memset.
> I thought about using asm.h but that header is visible to users and
> defining it there would be a visible change that could affect user
> programs.  sysdep.h is internal to glibc and so does not have that
> problem.

Seems reasonable.  This sysdep.h patch is OK.  Does it fix all 
__mips_isa_rev -Wundef warnings in the build (for the older MIPS versions 
for which this was an issue) or do some files need changing to include 
sysdep.h.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]