This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6

On Sat, 20 Dec 2014, Matthew Fortune wrote:

> Joseph Myers <> writes:
> > On Fri, 19 Dec 2014, Matthew Fortune wrote:
> > 
> > > > +#if __mips_isa_rev > 5
> > >
> > > I've just so happened to be starting some mips2 tests with glibc and
> > > found see that __mips_isa_rev is not defined below mips32.
> > > This is then an error given -Werror is in force.
> > 
> > We still have -Wno-error=undef, so it *shouldn't* be an error (but once
> > Siddhesh's remaining -Wundef fixes are in, and any further fixes needed
> > to get clean for -Wundef in at least one configuration, we should remove
> > -Wno-error=undef, so such issues certainly need fixing soon).
> Ah, OK. I think my build must have failed for a different reason
> and there was __mips_isa_rev warning close to the end that I
> misread as an error.
> I guess we can leave it to a cleanup commit for all the instances
> then.

I'll wait for the cleanup and revised versions of the memset / memcpy 
patches (on the basis that the identified -Wundef issue means that the 
memset / memcpy patches can't go in as-is).

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]