This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] always inline alloc_perturb.
- From: David Miller <davem at davemloft dot net>
- To: neleai at seznam dot cz
- Cc: roland at hack dot frob dot com, libc-alpha at sourceware dot org
- Date: Fri, 12 Dec 2014 09:34:17 -0500 (EST)
- Subject: Re: [PATCH] always inline alloc_perturb.
- Authentication-results: sourceware.org; auth=none
- References: <20141211203625 dot GA7490 at domone> <20141211205209 dot 6905E2C3ACD at topped-with-meat dot com> <20141212111856 dot GA8768 at domone>
From: Ondřej Bílka <firstname.lastname@example.org>
Date: Fri, 12 Dec 2014 12:18:56 +0100
> Compiler uses simple heuristics for inlining, not magic. It pretty often
> refuses to inline functions that after inlining he could say delete half
> code as dead. Reason why it should be inlined is simple, unlikely branch
> is much cheaper than function call.
This only tells me that the compiler should become more sophisticated
over time, not that we should forver assume it can't do a good job.
If we continue to hand inline things, there is zero incentive to
make the compiler smarter about it.