This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] always inline alloc_perturb.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 11 Dec 2014 12:52:09 -0800 (PST)
- Subject: Re: [PATCH] always inline alloc_perturb.
- Authentication-results: sourceware.org; auth=none
- References: <20141211203625 dot GA7490 at domone>
> to fix build error we change inline to always_inline. OK to commit?
What's the actual effect on code generation? The warnings I've seen for
this are because it had inlined, cloned, and outlined (so only the test was
inlined), which is probably optimal. In general, unless there is a strong
demonstrated reason to force inlining, we should usually just drop the
inline keyword and let the compiler decide.
> * malloc/malloc.c (alloc_perturb, free_perturb):
> use __always inline.
Capitalize a sentence. Typo: __always_inline.