This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] always inline alloc_perturb.


> Hi, 
> to fix build error we change inline to always_inline. OK to commit?

What's the actual effect on code generation?  The warnings I've seen for
this are because it had inlined, cloned, and outlined (so only the test was
inlined), which is probably optimal.  In general, unless there is a strong
demonstrated reason to force inlining, we should usually just drop the
inline keyword and let the compiler decide.

> 	* malloc/malloc.c (alloc_perturb, free_perturb):
> 	use __always inline.

Capitalize a sentence.  Typo: __always_inline.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]