This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Get rid of warning inlining failed in call to maybe_swap_uint32


Hi,

this patch disables warning/error:
In file included from programs/locarchive.c:49:0:
programs/locarchive.c: In function âadd_localeâ:
programs/locfile.h:85:1: warning: inlining failed in call to âmaybe_swap_uint32â: call is unlikely and code size would grow [-Winline]
programs/locarchive.c:981:12: warning: called from here [-Winline]

The function maybe_swap_uint32 isnÂt marked as inline anymore, which avoids the inlining warning. The unused attribute was added due to the inclusion of locfile.h in linereader.c, which does not use maybe_swap_uint32 function.

Tested on s390.

Ok to commit?

Bye
Stefan

---
2014-12-11  Stefan Liebler  <stli@linux.vnet.ibm.com>

	locale/programs/locfile.h (maybe_swap_uint32):
	Remove inline and add unused attribute.

Attachment: locarchive_11122014
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]