This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] scripts/check-local-headers.sh: Verify there is input (don't hang).
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 11 Dec 2014 14:22:55 +0000
- Subject: Re: [PATCH] scripts/check-local-headers.sh: Verify there is input (don't hang).
- Authentication-results: sourceware.org; auth=none
- References: <54890AA3 dot 4040706 at redhat dot com>
On Wed, 10 Dec 2014, Carlos O'Donell wrote:
> If you have a failed build, and run `make check` it could hang forever
> in check-local-headers.sh because the awk script waits reading stdin
> if the input shell glob expands to nothing (missing input).
> We have three options, close stdin, more awk to detect missing input
> or more shell. I chose the latter, but we could probably fix this with
> `exec 0>&-` in the shell if anyone objects to using find/grep or more
We have consensus to redirect test input from /dev/null (unless a test
needs input from some other file, of course). See bug 14753.
Joseph S. Myers