This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Fix unitialized variable


On Wed, 10 Dec 2014, Adhemerval Zanella wrote:

> The 'resolv/res_send.c' build with _STRING_ARCH_unaligned not defined
> may utilize the local resplen uninitialized.  This patch sets it to 0.

Do you have an actual path through the function that can result in it 
being used uninitialized, and where a value of 0 is correct?

My understanding, as described in 
<https://sourceware.org/ml/libc-alpha/2014-11/msg00693.html>, was that 
this is a false positive warning - the variable is never actually used 
uninitialized, but determining that requires considering the values other 
variables can have on the paths leading to resplen being used.  And since 
we don't want to add initializations (to installed code as opposed to 
testcases) that actually require code to be generated simply in order to 
avoid warnings, that may indicate disabling -Wmaybe-uninitialized around 
the code that generates the warning.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]