This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/N v2] [x86_64] Vectorized math functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 3 Dec 2014 17:56:52 +0000
- Subject: Re: [PATCH 4/N v2] [x86_64] Vectorized math functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3tnPWA=f_z5wQYroEFHqUrKiy2C6ytY=s_7BTzONPL4Zg at mail dot gmail dot com>
On Tue, 2 Dec 2014, Andrew Senkevich wrote:
> +#ifndef _MATH_H
> +# error "Never include <bits/libm-simd-decl-stubs.h> directly; \
> + include <math.h> instead."
> +#endif
If you continue a #error line like that, I think you should still ensure
there aren't excess spaces in the string (so either put the backslash
immediately after ';', with a single space's indentation on the next line,
or have no indentation on the next line at all).
> +#ifndef _LIBM_SIMD_DECL_STUBS_H
> +#define _LIBM_SIMD_DECL_STUBS_H 1
I think the header guard name should start with _BITS_ now it's a bits/
header.
> +#ifndef _MATH_H
> +# error "Never include <bits/math-vector.h> directly; \
> + include <math.h> instead."
Same point about avoiding multiple consecutive spaces in mid-sentence.
> +/* Get machine-dependent vector math functions declarations */
Comments should end ". */" (".", two spaces, end of comment).
--
Joseph S. Myers
joseph@codesourcery.com