This is the mail archive of the
mailing list for the glibc project.
Re: Add more headers to include/ for conform tests
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, libc-alpha at sourceware dot org, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Fri, 28 Nov 2014 14:28:26 -0500
- Subject: Re: Add more headers to include/ for conform tests
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411272041480 dot 15307 at digraph dot polyomino dot org dot uk>
On 11/27/2014 03:42 PM, Joseph Myers wrote:
> Carlos reported failures in conform/ tests in environments where the
> compiler used could only find headers in glibc's source and build
> trees, not any previously installed headers
> This patch adds wrappers for the affected headers to include/, which
> is the normal way to make headers visible when building or testing in
> directories other than the one containing the header (I suppose these
> headers weren't needed in any such directories except conform/, or
> other build or test failures would have resulted). I believe the same
> issue applies at least to regexp.h and re_comp.h - we don't currently
> have conform/ expectations for those, but when such expectations are
> added we'll also need to add header wrappers.
> The semaphore.h wrapper just includes nptl/semaphore.h - there's a
> question about whether this is logically correct, given the
> possibility of other thread library implementations. I suggested a
> couple of possible alternative approaches in
> Tested for x86_64 (testsuite, and that installed stripped shared
> libraries are unchanged by the patch). I did *not* test a
> configuration such as that in which Carlos saw failure.
> 2014-11-27 Joseph Myers <firstname.lastname@example.org>
> * include/cpio.h: New file.
> * include/fmtmsg.h: Likewise.
> * include/semaphore.h: Likewise.
This fixes the failures I see on Fedora 20.
Now I have only 200+ linknamespace failures :-)