This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 08/29] [AARCH64] Add header guards to sysdep.h headers.
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: Andrew Pinski <apinski at cavium dot com>, <libc-alpha at sourceware dot org>
- Date: Mon, 27 Oct 2014 12:32:40 -0400
- Subject: Re: [PATCH 08/29] [AARCH64] Add header guards to sysdep.h headers.
- Authentication-results: sourceware.org; auth=none
- References: <1414396793-9005-1-git-send-email-apinski at cavium dot com> <1414396793-9005-9-git-send-email-apinski at cavium dot com>
On 10/27/2014 3:59 AM, Andrew Pinski wrote:
* sysdeps/aarch64/sysdep.h: Add header guards.
[AARCH64] Remove 64 from some relocation names as they have been renamed in later versions of the spec.
The AARCH64 elf ABI spec renamed some relocations removing 64 from the TLS
relocation names to make them constaint with the ILP32 named ones.
* elf/elf.h (R_AARCH64_TLS_DTPMOD64): Rename to ..
(R_AARCH64_TLS_DTPMOD): This.
(R_AARCH64_TLS_DTPREL64): Rename to ...
(R_AARCH64_TLS_DTPREL): This.
(R_AARCH64_TLS_TPREL64): Rename to ...
(R_AARCH64_TLS_TPREL): This.
* sysdeps/aarch64/dl-machine.h (elf_machine_type_class): Update
R_AARCH64_TLS_DTPMOD64, R_AARCH64_TLS_DTPREL64, and R_AARCH64_TLS_TPREL64.
(elf_machine_rela): Likewise.
[AARCH64] Fix pltenter and pltexit for ILP32.
* sysdeps/aarch64/bits/link.h (la_aarch64_gnu_pltenter): Use
ElfW macro instead of hardcoded Elf64 types.
The git commit subject is too narrow and should also cover the other changes here, or more likely, you should break the sysdep.h header guard change into a separate change from the "64" suffix removal stuff for the elf.h headers.
That said, why exactly do you need header guards on sysdep.h? A quick audit suggests that some versions of sysdep.h do, some don't, so it feels like we have some confusion in the glibc build system such that this situation has developed. It would be nice to have a standard that we should, or should not, have header guards on this header.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com