This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] remove nested functions from elf/dl-lookup.c
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 8 Oct 2014 15:26:14 -0700
- Subject: Re: [PATCH] remove nested functions from elf/dl-lookup.c
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdwXd0AVUKRwtosJw+d5QujmqNspeVHG+2N9O+o1_F-KqQ at mail dot gmail dot com> <20141008221840 dot 99BFB2C3AC5 at topped-with-meat dot com>
Thanks!
On Wed, Oct 8, 2014 at 3:18 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> +/* We have to determine whether we already found a
>> + symbol with this name before. If not then we have to
>> + add it to the search table. If we already found a
>> + definition we have to use it. */
> [...]
>> - /* We have to determine whether we already found a
>> - symbol with this name before. If not then we have to
>> - add it to the search table. If we already found a
>> - definition we have to use it. */
>
> When you move a comment to a different indentation level, it's worth
> hitting M-q just to see if it comes out prettier in fewer lines.
>
> However, in this case the comment should not have been moved.
> It's describing the logic of do_lookup_unique, not of enter.
> The name "enter" is a bit too generic for a file-scope function.
>
> I fixed these things up and committed for you.
>
>
> Thanks,
> Roland