This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Write errors to stdout and not stderr in wcsmbs/tst-mbrtowc.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Arjun Shankar <arjun dot is at lostca dot se>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 3 Oct 2014 12:36:28 -0700 (PDT)
- Subject: Re: [PATCH] Write errors to stdout and not stderr in wcsmbs/tst-mbrtowc.c
- Authentication-results: sourceware.org; auth=none
- References: <20141003205833 dot 6deb3569 at zion>
The dup2 hack is either cute or horrible (likely both). I don't think we
should do anything like that in one random test. Rather, we should settle
on a uniform policy for tests and using assert. It could be that we never
use assert. Or it could be that we use assert freely and just make
test-skeleton.c always do the dup2 hack itself. Or it could be something
else I haven't thought of off hand. But let's get a plan.
If you'd like to convert these tests to use test-skeleton.c first as a
separate change before we figure out how to address the assert issue,
that could go in right away.
Thanks,
Roland