This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] stdlib/tst-strtod-round.c: Fix build on ARM
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: Will Newton <will dot newton at linaro dot org>, <libc-alpha at sourceware dot org>
- Date: Wed, 24 Sep 2014 15:13:17 +0000
- Subject: Re: [PATCH] stdlib/tst-strtod-round.c: Fix build on ARM
- Authentication-results: sourceware.org; auth=none
- References: <1410903170-31206-1-git-send-email-will dot newton at linaro dot org> <1410903170-31206-2-git-send-email-will dot newton at linaro dot org> <20140924145915 dot GO1716 at spoyarek dot pnq dot redhat dot com> <20140924150331 dot GQ1716 at spoyarek dot pnq dot redhat dot com>
On Wed, 24 Sep 2014, Siddhesh Poyarekar wrote:
> On Wed, Sep 24, 2014 at 08:29:15PM +0530, Siddhesh Poyarekar wrote:
> > On Tue, Sep 16, 2014 at 02:32:50PM -0700, Will Newton wrote:
> > > Building this test on ARM fails because the prototypes for the long
> > > double variants of the math functions are unavailable.
> > >
> > > Add an additional include guard to math.h that enables long double math
> > > function declarations if _LIBC_TEST is defined and define _LIBC_TEST in
> > > stdlib/tst-strtod-round.c.
> > >
> > > ChangeLog:
> > >
> > > 2014-09-16 Will Newton <will.newton@linaro.org>
> > >
> > > * math/math.h: Define long double math functions if
> > > _LIBC_TEST is defined.
> > > * stdlib/tst-strtod-round.c: Define _LIBC_TEST.
>
> Oh, and this needs a BZ.
I don't see why - it's not a bug that was user-visible in a release.
User programs, which should never define _LIBC or _LIBC_TEST, will have
got the required declarations anyway.
--
Joseph S. Myers
joseph@codesourcery.com