This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ 16852] Do not clobber recvmmsg argument.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org, David Miller <davem at davemloft dot net>, schwab at linux-m68k dot org
- Date: Sat, 20 Sep 2014 13:55:02 +0200
- Subject: Re: [PATCH v2][BZ 16852] Do not clobber recvmmsg argument.
- Authentication-results: sourceware.org; auth=none
- References: <20140428152937 dot GA1736 at domone dot podge> <20140428 dot 130122 dot 2188782190759376374 dot davem at davemloft dot net> <20140504153424 dot GA16138 at domone dot podge> <13674568 dot VK8Jx23VUu at vapier>
On Sat, Aug 02, 2014 at 10:16:40AM -0400, Mike Frysinger wrote:
> On Sun 04 May 2014 17:34:24 OndÅej BÃlka wrote:
> > On Mon, Apr 28, 2014 at 01:01:22PM -0400, David Miller wrote:
> > > From: OndÅej BÃlka <neleai@seznam.cz>
> > > Date: Mon, 28 Apr 2014 18:04:20 +0200
> > >
> > > > * sysdeps/unix/sysv/linux/recvmmsg.c (recvmmsg): Do not clobber
> > > > timeout argument.
> > >
> > > It is extremely unfortunate if we've defined this argument as const,
> > > now you are making it so that the user has no mechanism to get the
> > > updated timeval other than to define their own syscall stubs.
> > >
> > > This is doubly unfortunately since there is absolutely no reason for
> > > us to have defined the interface different from what the kernel
> > > actually provides.
> >
> > Ok, here is second alternative that drops constness.
>
> i think everyone agreed this was the best way to go for now
> -mike
As I decided to relax on holiday this waited a while. I pushed this now.