This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix to egrep for yes$ to avoid matching it on include paths
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Benjamin Esquivel <benjamin dot esquivel at linux dot intel dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 25 Aug 2014 18:45:00 +0200
- Subject: Re: [PATCH] Fix to egrep for yes$ to avoid matching it on include paths
- Authentication-results: sourceware.org; auth=none
- References: <1408939644-79389-1-git-send-email-benjamin dot esquivel at linux dot intel dot com>
Benjamin Esquivel <benjamin.esquivel@linux.intel.com> writes:
> diff --git a/sysdeps/aarch64/configure.ac b/sysdeps/aarch64/configure.ac
> index 7851dd4..6002697 100644
> --- a/sysdeps/aarch64/configure.ac
> +++ b/sysdeps/aarch64/configure.ac
> @@ -10,7 +10,7 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
> # the dynamic linker via %ifdef.
> AC_CACHE_CHECK([for big endian],
> [libc_cv_aarch64_be],
> - [AC_EGREP_CPP(yes,[#ifdef __AARCH64EB__
> + [AC_EGREP_CPP(yes$$,[#ifdef __AARCH64EB__
> yes
> #endif
It would be more robust to use AC_PREPROC_IFELSE and #error.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."