This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [all-arch][PATCH 00/19] Fix -Wundef warning in SHLIB_COMPAT
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 22 Aug 2014 18:01:06 +0000
- Subject: Re: [all-arch][PATCH 00/19] Fix -Wundef warning in SHLIB_COMPAT
- Authentication-results: sourceware.org; auth=none
- References: <1408618663-2281-1-git-send-email-siddhesh at redhat dot com> <20140822045700 dot GE16835 at spoyarek dot pnq dot redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1408221552170 dot 24669 at digraph dot polyomino dot org dot uk> <20140822173240 dot GI16835 at spoyarek dot pnq dot redhat dot com>
On Fri, 22 Aug 2014, Siddhesh Poyarekar wrote:
> On Fri, Aug 22, 2014 at 04:01:21PM +0000, Joseph S. Myers wrote:
> > Do you mean some previous patch in the series broke those exports and
> > patch 20/20 restored them? The exports appear in libc.abilist so I
> > presume are currently working as they should, or at least were working
> > recently. General principles of bisectability mean things should be
> > designed to stay working after each patch rather than patch 20 fixing
> > something broken by an earlier patch.
>
> I don't think any patches in my series broke it, but I haven't done a
> per-patch analysis for all architectures; I only did that for x86_64.
> For everything else I did comparisons at master, 5/20 and 20/20. In
> any case, I'm redoing those bits to reduce the impact on other bits.
Well, clearly this series should not change any symbol exports; if there
are bugs in the exports at present, the ABI testsuite should be showing
them up, and they should be fixed separately.
--
Joseph S. Myers
joseph@codesourcery.com