This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Disable x87 inline functions for x86_64 and SSE [BZ #17262]
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 12 Aug 2014 20:39:41 +0200
- Subject: Re: [PATCH] Disable x87 inline functions for x86_64 and SSE [BZ #17262]
- Authentication-results: sourceware.org; auth=none
- References: <20140812183008 dot GO9284 at spoyarek dot pnq dot redhat dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Aug 13, 2014 at 12:00:08AM +0530, Siddhesh Poyarekar wrote:
> --- a/sysdeps/x86/fpu/bits/mathinline.h
> +++ b/sysdeps/x86/fpu/bits/mathinline.h
> @@ -384,7 +384,10 @@ __END_NAMESPACE_C99
> # endif
> #endif
>
> -#ifndef __SSE2_MATH__
> +/* Disable x87 inlines when -fpmath=sse is passed and also when we're building
> + on x86_64. Older gcc (gcc-3.2 for example) does not set __SSE2_MATH__
I'd use predefine or define instead of set, otherwise LGTM. Thanks for
working on this.
> + for x86_64. */
> +#if !defined __SSE2_MATH__ && !defined __x86_64__
> # if ((!defined __NO_MATH_INLINES || defined __LIBC_INTERNAL_MATH_INLINES) \
> && defined __OPTIMIZE__)
>
> @@ -970,4 +973,4 @@ __inline_mathcode2 (__ieee754_atan2, __y, __x,
> return __value;)
> # endif
>
> -#endif /* !__SSE2_MATH__ */
> +#endif /* !__SSE2_MATH__ && !__x86_64__ */
Jakub