This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Fix gprof starting entry point for LE
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Wed, 30 Jul 2014 09:04:16 -0300
- Subject: Re: [PATCH] PowerPC: Fix gprof starting entry point for LE
- Authentication-results: sourceware.org; auth=none
- References: <53D7EF36 dot 2010101 at linux dot vnet dot ibm dot com> <53D80700 dot 5050207 at redhat dot com>
On 29-07-2014 17:41, Carlos O'Donell wrote:
> On 07/29/2014 03:00 PM, Adhemerval Zanella wrote:
>> This patch fixes the ELFv2 gprof entry point since the ABI
>> does not define function descriptors. It fixes BZ#17213.
>>
>> Checked on powerpc64le and it would be good if I can include it on 2.20
>> as well.
>>
>> --
>>
>> 2013-07-29 Adhemerval Zanella <azanella@linux.vnet.ibm.com>
>>
>> [BZ #17213]
>> * sysdeps/powerpc/powerpc64/entry.h: Fix TEXT_START definition for
>> powerpc64le.
> If it wasn't so close to 2.20 I'd ask to see if we could have written a
> regression test case for this that exercises gprof with the new libraries.
>
> We should have a way to have detected that this was broken without having
> to manually try gprof.
I will put in my backlog to create a testcase for gprof build.
>
> Cheers,
> Carlos.
>