This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix -Wundef warning for HAVE_OBSTACK
- From: Andreas Schwab <schwab at suse dot de>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 09 Jul 2014 10:16:26 +0200
- Subject: Re: [PATCH] Fix -Wundef warning for HAVE_OBSTACK
- Authentication-results: sourceware.org; auth=none
- References: <20140709070106 dot GA18813 at spoyarek dot pnq dot redhat dot com> <CANu=DmiEBiiXB8tazNRKTfweP7df6Zs-vmuEL1vAoLBq0tm8NA at mail dot gmail dot com>
Will Newton <will.newton@linaro.org> writes:
> I wonder if we could go further than this - it looks like we should be
> able to remove HAVE_CONFIG_H and HAVE_VALUES_H too.
>
> Also the define of bcopy seems redundant.
>
> And the definition of BITSPERBYTE. Maybe we can remove the include of
> values.h too?
I think the original intent was that the programs can also be built
standalone.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."