This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Wundef warning for __cplusplus


On 8 July 2014 19:04, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> All current uses of the __cplusplus macro only check if it is defined
> or not.  Fix this #if to use $ifdef like the rest of the code.
>
> This fixes the warning on i386.
>
> Siddhesh
>
>         * sysdeps/generic/unwind-pe.h: Only check if __cplusplus is
>         defined.
>
> ---
>  sysdeps/generic/unwind-pe.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks ok to me.

> diff --git a/sysdeps/generic/unwind-pe.h b/sysdeps/generic/unwind-pe.h
> index a4afe5c..a6ee414 100644
> --- a/sysdeps/generic/unwind-pe.h
> +++ b/sysdeps/generic/unwind-pe.h
> @@ -22,7 +22,7 @@
>     than duplicating code, however.  */
>
>  /* If using C++, references to abort have to be qualified with std::.  */
> -#if __cplusplus
> +#ifdef __cplusplus
>  #define __gxx_abort std::abort
>  #else
>  #define __gxx_abort abort
> --
> 1.9.3
>



-- 
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]