This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix -Wundef warning on PAGE_COPY_THRESHOLD


On Tue, Jul 01, 2014 at 09:23:05AM -0700, Roland McGrath wrote:
> This is not the way to do this.
> 
> Really the contents of pagecopy.h should move to memcopy.h, and
> generic/pagecopy.h should do nothing but #define PAGE_COPY_THRESHOLD 0.

Can't we just get rid of pagecopy.h?  All it will do is result in a
arch-specific copy of memcopy.h instead of pagecopy.h.  We can use the
same #undef ... #define method we used for MEMCPY_OK_FOR_FWD_MEMMOVE
in the arch-specific header..

Siddhesh

Attachment: pgpLWSmkkUEAJ.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]