This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] test-skeleton: Kill any child process's offspring
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-alpha at sourceware dot org>, Ondřej Bílka <neleai at seznam dot cz>
- Date: Mon, 30 Jun 2014 20:18:35 +0100
- Subject: Re: [PATCH v2] test-skeleton: Kill any child process's offspring
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1309231748080 dot 4379 at tp dot orcam dot me dot uk> <20131011163332 dot GA20086 at domone dot podge> <20140210171709 dot GA27843 at domone> <alpine dot DEB dot 1 dot 10 dot 1406230100010 dot 25395 at tp dot orcam dot me dot uk> <20140623173427 dot 7D80F2C3A0C at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1406232023480 dot 25395 at tp dot orcam dot me dot uk> <20140630182220 dot 279C02C398C at topped-with-meat dot com>
On Mon, 30 Jun 2014, Roland McGrath wrote:
> > + /* In case, setpgid failed in the child, kill it individually too. */
> > kill (pid, SIGKILL);
>
> Drop the first comma. Otherwise all looks right to me.
Applied. Thanks for your effort with the review.
Maciej