This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH roland/arm-aeabi] ARM: Move more aeabi routine magic out of Linux-specific directories
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Thu, 26 Jun 2014 15:10:20 -0700 (PDT)
- Subject: Re: [PATCH roland/arm-aeabi] ARM: Move more aeabi routine magic out of Linux-specific directories
- Authentication-results: sourceware.org; auth=none
- References: <20140626214443 dot B9EC92C39BC at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1406262156230 dot 11339 at digraph dot polyomino dot org dot uk>
> You appear to be copying this tests change, and the libpthread-*
> additions, from sysdeps/unix/sysv/linux/arm/Makefile but without removing
> it from that file, so leaving duplicate copies. OK with the duplicates
> removed (of course the libc-do-syscall additions to libpthread-* need to
> remain behind in sysdeps/unix/sysv/linux/arm/Makefile), presuming that
Oops. Removed those and committed.
> (The unwind info issue described shouldn't apply with binutils postdating
> 2009-05-05 Paul Brook <firstname.lastname@example.org>
> * bfd-in.h (elf32_arm_fix_exidx_coverage): Add prototype.
> * bfd-in2.h: Regenerate.
> * elf32-arm.c (arm_unwind_edit_type, arm_unwind_table_edit): Define.
> (_arm_elf_section_data): Add text and exidx fields.
> (add_unwind_table_edit, get_arm_elf_section_data, adjust_exidx_size,
> insert_cantunwind_after, elf32_arm_fix_exidx_coverage, offset_prel31,
> copy_exidx_entry): New functions.
> (elf32_arm_write_section): Fixup .ARM.exidx contents.
> which includes all supported binutils versions - but that's a separate
> matter, and it may be that the explicit cantunwind markers on intermediate
> frames aren't sufficient for the test to work, just for it not to use
> other functions' unwind info accidentally.)
OK. That is indeed orthogonal. If it's unnecessary and can be removed,
then please do that later.