This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [BZ 14094] Update locale data to Unicode 7.0.0
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Pravin Satpute <psatpute at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
- Date: Wed, 25 Jun 2014 11:06:55 +0000
- Subject: Re: [PATCH] [BZ 14094] Update locale data to Unicode 7.0.0
- Authentication-results: sourceware.org; auth=none
- References: <53A5DCA3 dot 4010108 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1406212027560 dot 29257 at digraph dot polyomino dot org dot uk> <1227269003 dot 32244068 dot 1403684984863 dot JavaMail dot zimbra at redhat dot com>
On Wed, 25 Jun 2014, Pravin Satpute wrote:
> These classes now disable in gen-unicode-ctype.c and also moved this
> file to scripts/
If you move and change a file at the same time, you should use "git diff
-M" so the changes to the file are shown, rather than separate deletion
and addition of the file. But I don't think moving to scripts/ is a good
idea. I think scripts/ should be for scripts relating to glibc as a
whole, and something specific to a particular subdirectory should go in
that subdirectory - so the new scripts should go in localedata/, and the
existing file stay there.
(That principle of scripts/ only being for scripts relating to glibc as a
whole would imply that some existing files in scripts/ should go
elsewhere, e.g. those that are only used by elf/ testcases. That's a
separate issue, nothing to do with your patch.)
--
Joseph S. Myers
joseph@codesourcery.com