This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Add adaptive elision to rwlocks v2
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: libc-alpha at sourceware dot org, carlos at redhat dot com, Andi Kleen <ak at linux dot intel dot com>
- Date: Fri, 13 Jun 2014 23:10:28 +0200
- Subject: Re: [PATCH 2/3] Add adaptive elision to rwlocks v2
- Authentication-results: sourceware.org; auth=none
- References: <1402532621-26622-1-git-send-email-andi at firstfloor dot org> <1402532621-26622-3-git-send-email-andi at firstfloor dot org>
Andi Kleen <andi@firstfloor.org> writes:
> @@ -102,6 +103,12 @@ __pthread_rwlock_rdlock (pthread_rwlock_t *rwlock)
>
> LIBC_PROBE (rdlock_entry, 1, rwlock);
>
> + if (ELIDE_LOCK (rwlock->__data.__rwelision,
> + rwlock->__data.__lock == 0
> + && rwlock->__data.__writer == 0
> + && rwlock->__data.__nr_readers == 0))
pthread_rwlock_rdlock.c: In function â__pthread_rwlock_rdlockâ:
pthread_rwlock_rdlock.c:106:3: warning: pointer targets in passing argument 1 of âelision_adaptâ differ in signedness [-Wpointer-sign]
if (ELIDE_LOCK (rwlock->__data.__rwelision,
^
In file included from pthread_rwlock_rdlock.c:25:0:
../sysdeps/x86/nptl/elide.h:29:1: note: expected âuint8_t *â but argument is of type âsigned char *â
elision_adapt(uint8_t *adapt_count, unsigned int status)
^
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."