This is the mail archive of the
mailing list for the glibc project.
Re: patchwork.sourceware.org is live!
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Siddhesh Poyarekar <siddhesh at redhat dot com>, gdb at sourceware dot org, GNU C Library <libc-alpha at sourceware dot org>, carlos at redhat dot com, fche at redhat dot com, gbenson at redhat dot com
- Date: Tue, 27 May 2014 11:57:14 +0530
- Subject: Re: patchwork.sourceware.org is live!
- Authentication-results: sourceware.org; auth=none
- References: <20140523211338 dot GK12497 at spoyarek dot pnq dot redhat dot com> <87a9a3spu4 dot fsf at kepler dot schwinge dot homeip dot net>
On 27 May 2014 11:52, Thomas Schwinge <firstname.lastname@example.org> wrote:
>> close patches you know you have already pushed into master.
> Does that mean changing the state to ÂAcceptedÂ (or ÂCommittedÂ, once
> that has been added), or ticking the ÂArchivedÂ box, or both? What's the
> meaning of the ÂArchivedÂ box?
Only change to Accepted for now, since nobody has commented on my
suggestion to add a new Committed status. I have no idea what the
Archived checkbox does :)
> So, does patchwork's ÂDelegate toÂ Patch Property equal Bugzilla's
> ÂAssigned ToÂ field? And, it is not totally clear to my why the Patch
> Review Workflow suggests to Ânot change the status of the patchÂ if
> Âchanging the Delegate to value to their patchwork usernameÂ?
That suggestion is no longer necessary. I have added the 'Under
Review' and 'Change Requested' statuses to the default view, so
changing state should not make those patches disappear from the queue
unless the state is Accepted, Superseded, RFC or Rejected.
> "In a perfect world", after a patch review, during which ÂDelegate toÂ
> has been set to the reviewer(s), should it then be changed to the person
> who is responsible for committing the patch (which may be the submitter,
> or the reviewer, or someone else), together with changing the state to
Yes, that would be good idea.