This is the mail archive of the
mailing list for the glibc project.
Re: [COMMITTED] PowerPC: Remove 64 bits instructions in PPC32 code
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Mon, 26 May 2014 13:12:02 -0500
- Subject: Re: [COMMITTED] PowerPC: Remove 64 bits instructions in PPC32 code
- Authentication-results: sourceware.org; auth=none
- References: <53834CE6 dot 2080802 at linux dot vnet dot ibm dot com>
> This patch replaces the insrdi by insrwi in powerpc32 assembly. Although they
> are not wrong, since all POWER chips supported in 32-bits are 64-bits and the chips
> do not thrown an illegal exception when running these instructions, valgrind
> fails accusing an invalid one.
This code is CPU-specific; as you say, those CPUs can use rldimi just
fine. The reason the code uses rldimi instead of rlwimi is because
it is faster (at least on power4, power5). Fix valgrind instead?