This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH 1/6] aarch64: Merge rtld_errno offset with memory reference
- From: Richard Henderson <rth at twiddle dot net>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org, marcus dot shawcroft at gmail dot com, Richard Henderson <rth at redhat dot com>
- Date: Fri, 23 May 2014 13:34:51 -0700
- Subject: Re: [PATCH 1/6] aarch64: Merge rtld_errno offset with memory reference
- Authentication-results: sourceware.org; auth=none
- References: <1400619378-7262-1-git-send-email-rth at twiddle dot net> <1400619378-7262-2-git-send-email-rth at twiddle dot net> <20140523203142 dot 8A8D12C3B6D at topped-with-meat dot com>
On 05/23/2014 01:31 PM, Roland McGrath wrote:
>> - add x1, x1, #:lo12:C_SYMBOL_NAME(rtld_errno); \
>> neg w0, w0; \
>> - str w0, [x1]; \
>> + str w0, [x1, :lo12:C_SYMBOL_NAME(rtld_errno)]; \
> Can we stay consistent about whether we use the # or not?
It's required in the context of the add, and not required (but accepted) in the
context of an address operand.
Personally, I prefer not using # in an address; which form do the AArch64