This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] AArch64: Fix handling of nocancel syscall failures


On Mon, May 19, 2014 at 03:53:54PM +0100, Will Newton wrote:
> 2014-05-19  Will Newton  <will.newton@linaro.org>
> 
> 	* sysdeps/unix/sysv/linux/aarch64/nptl/sysdep-cancel.h (PSEUDO):
> 	Test the return value of the system call in the nocancel case.
> ---
>  sysdeps/unix/sysv/linux/aarch64/nptl/sysdep-cancel.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> Note that I suspect the reason I saw this issue was due to some change in
> the way sysdep-cancel.h is getting included which may or may not be
> correct.
> 

I hit the same thing this week in Fedora... I ended up bisecting the
change to

commit 2fbdf5339aaeaa423bd661524f7ec7af41fa2606
Author: Roland McGrath <roland@hack.frob.com>
Date:   Wed May 14 11:06:36 2014 -0700

    Consolidate not-cancel.h files.

which makes some sense, since it looks like we may have previously not
been using the correct calls until this patch, and hence why prior to
this, without your fix, we weren't seeing obvious failures in the
test-suite.

regards, Kyle


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]