This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] ptsname_r: don't leak uninitialized memory (BZ #16917)
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 14 May 2014 12:53:16 +0200
- Subject: Re: [PATCH v3] ptsname_r: don't leak uninitialized memory (BZ #16917)
- Authentication-results: sourceware.org; auth=none
- References: <1400053732-29679-1-git-send-email-aurelien at aurel32 dot net> <mvmtx8su3g9 dot fsf at hawking dot suse dot de>
On Wed, May 14, 2014 at 11:14:46AM +0200, Andreas Schwab wrote:
> Aurelien Jarno <aurelien@aurel32.net> writes:
>
> > + /* Test with a terminal device which is not a PTS master. */
> > + fd = open (DEV_TTY, O_RDONLY);
> > + if (fd != -1)
> > + {
> > + do_single_test (0, buf, sizeof (buf), ENOTTY);
>
> Why do you ignore the return value here?
>
Because I haven't proofread my patch enough, thanks for spotting this.
I'll send a v4 soon.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net