This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix nl_langinfo with static linking


> +	($(objpfx)tst-langinfo.out): Redirect output.

Mention use of $(evaluate-test) too.

> +    default:                   /* Should be impossible.  */
> +      return (char *) "";

Make this an assert or abort rather than having the library function return
the user error indication for a case that is an implementation bug.

Otherwise looks fine to me (with BZ# added).


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]