This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linux, x86: Add 32 bit vDSO time function support


On Sun, 2014-04-20 at 13:34 -0400, Rich Felker wrote:
> On Sat, Apr 19, 2014 at 10:08:04AM +0200, Stefani Seibold wrote:
> > This patch add support for 32 bit vDSO time functions provided by the linux
> > kernel 3.15, which will be also supported the ia32 emulation mode.
> 
> This patch looks excessively large considering that it's just adding
> to 32-bit x86 functionality which is already implemented for x86_64. I
> believe it also already exists for ppc and maybe some other archs. If
> it really requires this much code duplication to add the same feature
> to each arch, I think some serious refactoring is called for...
> 

I am not sure what you expect...

But i have not the GLIBC knowledge nor the test equipment to unify and
refactoring the whole VDSO functionality in GLIBC. Since this kind of
rework impact a lot of different architectures it would need a lot of
tests.

All i can offer is to do a #include "../<x86_64 file>.c" instead of
duplicating the code.

- Stefani



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]