This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Updated rwlock-in-C patchkit

On Tue, 2014-04-29 at 19:13 -0400, Carlos O'Donell wrote:
> On 04/18/2014 05:12 PM, Andi Kleen wrote:
> > Andi Kleen <> writes:
> > 
> >> "Carlos O'Donell" <> writes:
> >>>
> >>> That's right. I'd like to see the whatever code was used to benchmark
> >>> the performance submitted as a microbenchmark so I can run it myself
> >>> and verify. Again, it's not that I don't trust Andi, but an objective
> >>> evaluation is always going to be the best defense for these changes.
> >>
> >> Here is the code I used:
> > 
> > Any comments now? Is the code ok to commit now?

I've seen a few minor issues (see reply to patch).

> > If yes please someone with access rights commit it.
> Sorry, April is busy.
> Torvlad, Have you had a chance to look at this?

Someone needs to put this benchmark into benchtest form.  (Otherwise, we
won't fulfill your requirement of having microbenchmarks...)

We could also consider adding a scalability benchtest for the rwlock,
and using the single thread data from it to compare.  That's on my list
of things to do, but haven't gotten to this yet.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]