This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [WIP] Fix HAVE_CONFIG_H -Wundef warnings.

On 2 May 2014 09:24, Carlos O'Donell <> wrote:

Hi Carlos,

> Is fixing the HAVE_CONFIG_H -Wundef warnings as easy as this?
> diff --git a/Makeconfig b/Makeconfig
> index f965398..64b64fc 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -1081,6 +1081,9 @@ endif
>  sysd-rules-targets := $(sort $(foreach p,$(sysd-rules-patterns),\
>                                          $(firstword $(subst :, ,$p))))
> +# We always configure glibc such that config.h is available.
> +defines += -DHAVE_CONFIG_H=1
> +
>  # A sysdeps Makeconfig fragment may set libc-reentrant to yes.
>  ifeq (yes,$(libc-reentrant))
>  defines += -D_LIBC_REENTRANT
> ---
> Followed by the mechanical change of all the `#idfef HAVE_CONFIG_H`
> to `#if HAVE_CONFIG_H`.
> Then verify the built binaries are identical and pass the testsuite?
> We always create a config.h for glibc so this looks correct.
> I don't want to waste my time fixing all of this if I've got it wrong.

A reasonable number of these are from files shared with gnulib. The
gnulib versions of the files have in some cases switched to use
#ifndef _LIBC instead of #if HAVE_CONFIG_H  but I haven't delved into
why that is yet.

Will Newton
Toolchain Working Group, Linaro

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]