This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] locks: rename file-private locks to file-description locks
- From: "Michael Kerrisk (man-pages)" <mtk dot manpages at gmail dot com>
- To: Andy Lutomirski <luto at amacapital dot net>, Jeff Layton <jlayton at redhat dot com>, Rich Felker <dalias at libc dot org>
- Cc: mtk dot manpages at gmail dot com, libc-alpha <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, samba-technical at lists dot samba dot org, linux-kernel at vger dot kernel dot org, "Stefan (metze) Metzmacher" <metze at samba dot org>, linux-fsdevel at vger dot kernel dot org, Ganesha NFS List <nfs-ganesha-devel at lists dot sourceforge dot net>
- Date: Mon, 21 Apr 2014 20:43:02 +0200
- Subject: Re: [PATCH] locks: rename file-private locks to file-description locks
- Authentication-results: sourceware.org; auth=none
- References: <1398087935-14001-1-git-send-email-jlayton at redhat dot com> <20140421140246 dot GB26358 at brightrain dot aerifal dot cx> <535529FA dot 8070709 at gmail dot com> <20140421161004 dot GC26358 at brightrain dot aerifal dot cx> <20140421124508 dot 4f2c9ca7 at tlielax dot poochiereds dot net> <53555CF0 dot 8030405 at mit dot edu>
On 04/21/2014 08:01 PM, Andy Lutomirski wrote:
> On 04/21/2014 09:45 AM, Jeff Layton wrote:
>> On Mon, 21 Apr 2014 12:10:04 -0400
>> Rich Felker <dalias@libc.org> wrote:
>>> I'm well aware of that. The problem is that the proposed API is using
>>> the two-letter abbreviation FD, which ALWAYS means file descriptor and
>>> NEVER means file description (in existing usage) to mean file
>>> description. That's what's wrong.
>>>
>>
>> Fair enough. Assuming we kept "file-description locks" as a name, what
>> would you propose as new macro names?
>
> F_OFD_...? F_OPENFILE_...?
>
> If you said "file description" to me, I'd assume you made a typo. If,
> on the other hand, you said "open file" or "open file description" or,
> ugh, "struct file", I think I'd understand.
"Open file description locks" is a mouthful, but, personally, I could
live with it. "struct file" is not a term that belongs in user-space.
"open file" is too ambiguous, IMO.
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/