This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] test-skeleton.c: Use stderr for error messages


On Fri, Apr 11, 2014 at 02:39:21PM +0100, Will Newton wrote:
> On 11 April 2014 14:16, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> > On Fri, Apr 11, 2014 at 11:00:29AM +0100, Will Newton wrote:
> >> At the moment a mixture of stderr and stdout is used for error
> >> messages. Switch to using stderr for consistency.
> >>
> >> ChangeLog:
> >>
> >> 2014-04-09  Will Newton  <will.newton@linaro.org>
> >>
> >>       * test-skeleton.c (create_temp_file): Use stderr for
> >>       outputting error messages.  (main): Likewise.
> >
> > There was a discussion in the past about sticking to stdout for
> > everything for consistency.  I can't find the link to it, but it is
> > mentioned on the wiki:
> >
> > https://sourceware.org/glibc/wiki/Testing/Testsuite#Writing_a_test_case
> 
> So we should really be going the other way and outputting everything to stdout?

Yes, that is also why we avoid using perror in test cases.  There are
some that do, but they need to be updated.

Ideally I think we need a WARN status for test cases that want to warn
of a condition and not actually fail, but that's probably something
for later.

Siddhesh

Attachment: pgpW5pFchSaGw.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]