This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #16823] S390: Fix log1pl returning wrong infinity sign
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 10 Apr 2014 00:09:24 +0200
- Subject: Re: [PATCH][BZ #16823] S390: Fix log1pl returning wrong infinity sign
- Authentication-results: sourceware.org; auth=none
- References: <li3hm5$hus$1 at ger dot gmane dot org>
On Wed, Apr 09, 2014 at 03:24:21PM +0200, Stefan Liebler wrote:
> Hi,
>
> on S390 test-double fails for log1pl(-1) with infinity has wrong
> sign in rounding mode FE_DOWNWARD. See Bug 16823.
> In this rounding mode, (x-x) = -0.
> In all other rounding modes, (x-x) = +0.
> A division with divisor -0 leads to +inf, while +0 results in -inf
> as expected. This patch changes the divisor to a const +0.
> Tested on s390/s390x.
>
> Is this okay?
>
Looks ok.
Perhaps we could add constants for infinity and nan would to write
return value directly.